Rework SCM stageModified status
#880
Conversation
| @@ -1,2 +0,0 @@ | |||
| export const isStringInEnum = (s: string, E: Record<string, string>) => | |||
| Object.values(E).includes(s) | |||
There was a problem hiding this comment.
[F] This is dead now. The only usage is gone.
mattseddon
changed the title
stageModified status
… remove-checkout-commit-from-staged
| ) | ||
|
|
||
| this.gitModifiedResourceGroup = this.dispose.track( | ||
| scmView.createResourceGroup('gitModified', 'Need Git Commit') |
There was a problem hiding this comment.
[C] Open to suggestions for this. It's basically a placeholder. There is no action to be performed as far as DVC is concerned.
There was a problem hiding this comment.
alternative could be Ready for SCM commit
There was a problem hiding this comment.
I like "Ready for" better than "Need". I'd vote for "Ready for Git commit".
| ) | ||
|
|
||
| this.gitModifiedResourceGroup = this.dispose.track( | ||
| scmView.createResourceGroup('gitModified', 'Need Git Commit') |
There was a problem hiding this comment.
I like "Ready for" better than "Need". I'd vote for "Ready for Git commit".
|
Code Climate has analyzed commit 3a885ad and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.4% (0.0% change). View more on Code Climate. |
This PR renames the
stageModifiedSCM status togitModified, splits these resources out into their own group within the SCM tree and names that group "Need Git Commit" in the UI.For detailed explanation on how/why I arrived at this change take a look here. TL;DR is this means I can drop inline commands from
gitModifiedresources (because they don't make sense) and also it provides a way of showing the user what to do next.Demo
Screen.Recording.2021-10-07.at.2.31.20.pm.mov
Note: At one stage the above demo exhibits this bug. I click on what should be our commit action but it actually fires the git one 🤸🏻. Luckily this bug is only in insiders for now.